Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Arabic translation for Excluding #579

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

FajarKim
Copy link
Contributor

Description

Add Arabic, Japanese, Polski, Svenska, and Kiswahili translations for Excluding

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@FajarKim FajarKim changed the title fix: Add Arabic, Japanese, Polski, Svenska, and Kiswahili translations for Excluding feat: Add Arabic, Japanese, Polski, Svenska, and Kiswahili translations for Excluding Sep 11, 2023
@DenverCoder1
Copy link
Owner

Looks good to me. Do you speak all of these languages?

@FajarKim
Copy link
Contributor Author

Looks good to me. Do you speak all of these languages?

Hmmm... I understand a little Arabic

@FajarKim
Copy link
Contributor Author

Maybe you can just add Arabic

@DenverCoder1
Copy link
Owner

Thanks, while chatgpt seems to say these are all fine, I think it's better if we leave it up to native speakers to decide on how things should be translated.

I'll merge Arabic, but leave the others open to other contributors if that's fine with you.

@FajarKim
Copy link
Contributor Author

Thanks, while chatgpt seems to say these are all fine, I think it's better if we leave it up to native speakers to decide on how things should be translated.

I'll merge Arabic, but leave the others open to other contributors if that's fine with you.

Yes, of course. I don't mind

@DenverCoder1 DenverCoder1 changed the title feat: Add Arabic, Japanese, Polski, Svenska, and Kiswahili translations for Excluding feat: Add Arabic translation for Excluding Sep 12, 2023
@DenverCoder1 DenverCoder1 merged commit 7c4f0d5 into DenverCoder1:main Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants