Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Consistent ID naming, redundant return, styling #443

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented Jan 30, 2023

Description

  • Made id/class naming style consistent
  • Make clear button disabled by default (on page load)
  • Make details summary show pointer cursor
  • Remove redundant return for button click events
  • More saturated default color that's a little easier to look at

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 added the refactor Code changes that do not affect the application behavior label Jan 30, 2023
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-refactor-1-d6okx4 January 30, 2023 19:32 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-refactor-1-qytazs January 30, 2023 19:39 Inactive
@DenverCoder1 DenverCoder1 merged commit af2aa49 into main Jan 30, 2023
@DenverCoder1 DenverCoder1 deleted the refactor/1-30 branch January 30, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that do not affect the application behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant