Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Clear advanced props button #438

Merged
merged 5 commits into from
Jan 30, 2023
Merged

feat: Clear advanced props button #438

merged 5 commits into from
Jan 30, 2023

Conversation

timagixe
Copy link
Contributor

Description

Fixes #433

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Screen.Recording.2023-01-28.at.6.40.46.PM.online-video-cutter.com.mp4

@timagixe timagixe mentioned this pull request Jan 30, 2023
Closed
@timagixe timagixe force-pushed the issue-433-clear-advanced-props-on-theme-change branch from a2f4def to 7163531 Compare January 30, 2023 18:15
@timagixe timagixe force-pushed the issue-433-clear-advanced-props-on-theme-change branch from 7163531 to 5e3c2ed Compare January 30, 2023 18:35
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-issue-433--pxq0yy January 30, 2023 18:56 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-issue-433--tfwsxz January 30, 2023 19:04 Inactive
DenverCoder1
DenverCoder1 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Clear advanced props on theme change feat: Clear advanced props button Jan 30, 2023
@DenverCoder1 DenverCoder1 merged commit 793afe0 into DenverCoder1:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear advanced properties when changing theme
2 participants
@timagixe @DenverCoder1