Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Urdu (Pakistan) Translations #425

Merged
merged 1 commit into from
Jan 18, 2023
Merged

feat: Added Urdu (Pakistan) Translations #425

merged 1 commit into from
Jan 18, 2023

Conversation

mosamaasif
Copy link
Contributor

Description

Ref: #236

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have one comment below, let me know what you think.

@@ -219,6 +219,15 @@
"Longest Week Streak" => "Найбільша к-сть тижнів",
"Present" => "Наразі",
],
"ur_PK" => [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should preferably be just "ur", unless Urdu (Pakistan) is different enough from Urdu (India) that it needs to be translated separately.

Suggested change
"ur_PK" => [
"ur" => [

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. So there are a few structural differences between the two versions and there are some words as well that are either spelt differently or are totally different. I think it would be better that they are kept different, but later on if someone comes in to translate for "ur" I think they will be able to alias this if they believe ur_PK works for that version too.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@DenverCoder1 DenverCoder1 merged commit f578750 into DenverCoder1:main Jan 18, 2023
@DenverCoder1 DenverCoder1 changed the title Added Urdu (Pakistan)(ur_PK) Translations feat: Added Urdu (Pakistan) Translations Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants