Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated Kannada translations #418

Merged
merged 1 commit into from
Jan 17, 2023
Merged

feat: Updated Kannada translations #418

merged 1 commit into from
Jan 17, 2023

Conversation

Vaibhav67979
Copy link
Contributor

@Vaibhav67979 Vaibhav67979 commented Jan 16, 2023 •
edited by DenverCoder1
Loading

Description

Added new and updated the existing kannada("kn") language translations...

issue #236

Updated a previously existing translation to be more precise and added new translations.

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

DenverCoder1
DenverCoder1 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title updated kannada("kn") language support feat: Updated Kannada translations Jan 17, 2023
@DenverCoder1 DenverCoder1 merged commit db4792b into DenverCoder1:main Jan 17, 2023
@Vaibhav67979
Copy link
Contributor Author

Looks great! Thanks for the contribution 🎉

Thanks! It was my pleasure to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vaibhav67979 @DenverCoder1