Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pashto translations #396

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Added Pashto translations #396

merged 2 commits into from
Dec 28, 2022

Conversation

Halim-Shams
Copy link
Contributor

@Halim-Shams Halim-Shams commented Dec 28, 2022

Description

Ref: #236

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

## Description
Fixes DenverCoder1#236

### Type of change
- [x] New feature (added a non-breaking change which adds functionality)

## How Has This Been Tested?
- [x] Tested locally with a valid username
- [x] Tested locally with an invalid username
- [x] Ran tests with composer test
- [x] Added or updated test cases to test new features

## Checklist:
- [x] I have checked to make sure no other pull requests are open for this issue
- [x] The code is properly formatted and is consistent with the existing code style
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit 4e8f36c into DenverCoder1:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants