fix(ask): loopback gate applies to proxy mode only, not snippet - #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loopback target check ran before mode selection, so it blocked snippet mode too — but snippet mode doesn't proxy: the developer's own server serves the app at its real origin and Caliper only injects a
<script>tag. So it needlessly rejected a real dev server at a custom hostname or over HTTPS (https://foo.local.example:4220), even when that host resolves to 127.0.0.1.Now the loopback + reachability gate applies only in proxy mode. In snippet mode
caliper_askaccepts any host — and because the origin never shifts to 127.0.0.1, the proxy-mode side effects vanish too (no third-party-key origin 403s like Google Maps, no CORS shift on the app's own API).caliper_designis proxy-only, so it's unchanged. Error message + skill guidance updated.Verified: tsc + eslint clean, 189 tests.