Skin EL to look like a DC project #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result we also add `django-pipeline` and configure it to use `assets` as the base assets storage directory. We'll remove `assets-src` and the gulp pipeline in another commit.
Now supports Session Tokens for Lambda
Also add an "in the last month" leaflet counter.
Use CSS Grid to display a grid of 3 cols on desktop, 1 on mobile
The "this year" count actually means "since 2015". So let's just remove it and speed everything up a whole bunch.
The data is broken, don't try to use it for now
Hard-coded start date
If there was no analysis for a particular party, we were showing the overall leaflet stats for that party. Easiest thing to do is exclude the party from the list
These aren't working yet, and could be server side rendered and cached.
We're hitting our Lambda function and layer limit, so we need to trim the archives we're uploading. The `media/` directory is no longer needed at all now we're using the DC Base Theme. We can use a newer version of serverless-python-requirements that will allow us to exclude certain directories from the requirements archive. We don't need the translations from `localflavor`, just a GB Postcode field.
Editable doesn't work properly with Pipenv and serverless-python-requirements
|
Sorry it's taken me a while to look at this! Everything looks good to me. There is a load of stuff that might break the deployment (S3 stuff, for example) or might need work later (odd styling issues here and there), but I reckon it's best to deploy this and fix stuff later, rather than try to anticipate it all up front. Great improvement in general – especially deleting loads of old stuff :) |
symroe
approved these changes
Sep 16, 2019
We want to have staging and production staticfiles coexist in the same S3 bucket, so we switch to using ManifestFileMixin and the PipelineMixin to generate hashes and manifest files per environment. We add a hook to the serverless deployment script so that collectstatic is run automatically for us
We use Django Pipeline now, no need for Gulp
Visiting `/test` will generate a list of links to various pages across the site for testing purposes. It links to random leaflets, constituencies etc.
This is no longer needed, but gets used for local development, so shouldn't be committed
They bloat the upload and are not actually used for tests
We need to include the correct `ManifestFinder` in `STATICFILES_FINDERS` in order to use the versioned styles.css instead of the generic one. Also use the `static` templatetag to get the hashed URL
boffbowsh
force-pushed
the
dc-base-theme
branch
from
8ee005a to
9a906a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a load of old unneeded frontend code, specifically all the Ember and Gulp stuff and switches to using dc_base_theme and django-pipelines.
This is best reviewed commit by commit as there's a few decisions about removing things.
To take it for a test drive, see staging: https://staging.democracyclub.org/ and the test page https://staging.democracyclub.org/test/
☝️ actually these are down at the moment as AWS has broken the deployment.