Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the design system installable via
pip
or other standard python packaging tools.For testing before merge, use
pip install git+https://github.com/DemocracyClub/design-system.git@python-package
.This will install a python package that can be imported:
import dc_design_system
The only thing this package does is to expose the directory it lives in:
This tells us that the
system
folder in this repo is at/home/symroe/.envs/design_system/lib/python3.8/site-packages/dc_design_system/system
.This path can be used by
libsass
as aninclude-path
, meaning that, once installed you can write project level sass assuming thesystem
is assessable.e.g, you can do this:
@import 'partials/_button.scss';
TODO
python
to indicate that this is about python, assuming we might want to include other package managers in the future. Does this make sense? Should it bepython-package
or something?system/partials/_button.scss
is less clear thandc_design_system/partials/_button.scss
(or whatever). I can rename this in the python package of course.