Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer changes #140

Closed
magdamaciaszczyk opened this issue Mar 28, 2019 · 3 comments
Closed

Footer changes #140

magdamaciaszczyk opened this issue Mar 28, 2019 · 3 comments
Assignees

Comments

@magdamaciaszczyk
Copy link

Changes discussed with Joe:

  • Split footer into two parts: links at the top (#403F41), mission statement and company info below (#000000).

  • Links at the top grouped into three categories: 'Who Can I Vote For?', 'Made by Democracy Club', 'Connect with us' (you can rename these). Each category has links related to either WCIVF, Democracy Club or social media.

  • Links on phone screens will use the one column layout and be displayed under each other.

  • Links on larger screens (from the size of a tablet screen in portrait view) will use a three column layout and be displayed in parallel columns.

  • Mission statement, copyright, company information at the bottom of the page on a darker background.

  • Headings in white, in bolder font.

  • Headings, links, mission statement, copyright can use the same font sizes as it is currently or copyright could be about 2px smaller (relative to the screen size).

Designs attached, let me know if you have any questions.

Desktop:
homepage-desktop-v4

Mobile:
homepage-mobile-v4

Tablet:
homepage-tablet-v4

@symroe symroe transferred this issue from DemocracyClub/WhoCanIVoteFor Sep 1, 2024
@symroe
Copy link
Member

symroe commented Sep 1, 2024

The work here is to implement the 'two colour' footer. We can use a Switcher to implement the columns in the top part, and simply centre align the lower part.

I suggest the HTML be something like this:

<footer>
  <div class="footer-links">
    <nav>
      <h2>Section heading</h2>
      <ul>
        <li><a href="#">Link</a></li>
        <li><a href="#">Link</a></li>
      </ul>
    </nav>
    <nav>
      <h2>Section heading</h2>
      <ul>
        <li><a href="#">Link</a></li>
        <li><a href="#">Link</a></li>
      </ul>
    </nav>
    <nav>
      <h2>Section heading</h2>
      <ul>
        <li><a href="#">Link</a></li>
        <li><a href="#">Link</a></li>
      </ul>
    </nav>    
  </div>

  <div class="footer-info">
    <p>Text</p>
  </div>
</footer>

And the SCSS can have footer > .footer-links extend from switcher, and .footer-info extend from ds-text-centered.

I think there's room for a logo at the top of footer-info, but this can be just the tick on its own line, to get around the centre issue.

@symroe
Copy link
Member

symroe commented Sep 1, 2024

Then of course all the projects need to be updated…

@pmk01
Copy link

pmk01 commented Nov 6, 2024

Hurrah, we did it.

@pmk01 pmk01 closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants