Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out legacy parties #1678

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Filter out legacy parties #1678

merged 1 commit into from
Aug 17, 2023

Conversation

Bekabyx
Copy link
Contributor

@Bekabyx Bekabyx commented Aug 16, 2023

Asana

This work addresses a bug which Peter found where we're serving some legacy parties on the party lookup page. There's a little more detail on the Asana ticket, but essentially any party starting with "ynmp" is legacy.

There are two notable exceptions to this, and those are Speaker Seeking Re-election and Independent. This means the logic isn't quite as straightforward so I've had to import Q to get the filter just right 👌

To test locally:

  • Open up the parties page locally
  • Make sure Independent and Speaker seeking re-election are in the list
  • "National Liberal Party, The Third Way" should NOT be in the list (gotcha: there is a party called National Liberal Party - True Liberalism. This one is supposed to be in the list.)

PR Checklist

Preview Give feedback

Copy link
Contributor

@VirginiaDooley VirginiaDooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally 🚀

@Bekabyx Bekabyx merged commit e0ab901 into master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants