Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/party nations #1655

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Feature/party nations #1655

merged 3 commits into from
Jul 20, 2023

Conversation

Bekabyx
Copy link
Contributor

@Bekabyx Bekabyx commented Jul 13, 2023

Trello

Blocked by DemocracyClub/yournextrepresentative#2147

Lumped in some minor text changes at Peter's request, so this PR also closes #1638 🔐

This work adds a breakdown of which nations parties can field candidates in. The change only applies to non-joint parties on the GB register.

Example:

Screenshot 2023-07-15 at 12 42 53

To test:

YNR setup

  • Follow the first two steps in the YNR PR to get your local YNR set up
  • Run the YNR server on some other port (e.g. manage.py runserver 4444)

WCIV setup

  • in base.py, override YNR_BASE to point at your local YNR on its new port (e.g. YNR_BASE = "http://0.0.0.0:4444")
  • run manage.py migrate
  • run manage.py import_parties

Tests

No change

Northern Ireland

  • Go to the party page for any Northern Irish party
  • The text at the top should read "This party is/was on the Northern Ireland register." as in the image below
Screenshot 2023-07-15 at 12 50 20

Joint Party

  • Go to the party page for any joint party
  • The text at the top should read "This party is/was on the Northern Ireland/Great Britain register." as in the image below
Screenshot 2023-07-15 at 12 51 37

Changes

The steps for these are the same. Find parties with one, two and three registered nations and check that the text is formatted as in the below images.

Party registered in one nation

Screenshot 2023-07-15 at 12 58 53

Party registered in two nations

Screenshot 2023-07-15 at 12 56 46

Party registered in three nations

Screenshot 2023-07-15 at 12 59 22

PR Checklist

Preview Give feedback

@coveralls
Copy link

coveralls commented Jul 15, 2023

Coverage Status

coverage: 60.931% (+0.1%) from 60.81% when pulling 20388c2 on feature/party_nations into 867173d on master.

@Bekabyx Bekabyx force-pushed the feature/party_nations branch 2 times, most recently from 5af5a1c to 1559dcc Compare July 15, 2023 11:08
@Bekabyx Bekabyx requested review from VirginiaDooley and symroe July 15, 2023 12:02
@Bekabyx Bekabyx force-pushed the feature/party_nations branch from 1559dcc to 37d932a Compare July 17, 2023 15:58
@Bekabyx Bekabyx marked this pull request as ready for review July 17, 2023 15:58
@Bekabyx Bekabyx force-pushed the feature/party_nations branch from 37d932a to d545d4e Compare July 20, 2023 09:57
@Bekabyx Bekabyx force-pushed the feature/party_nations branch from c8d6444 to 20388c2 Compare July 20, 2023 11:05
@Bekabyx Bekabyx merged commit 6059f98 into master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superfluous 'the' on joint party pages
3 participants