Feature/party pages update

[Bekabyx]

Trello
This PR is a somewhat fiddly collection of little things. Currently blocked by yournextrepresentative#2100.

To test

Pre-test - YNR

There's an amount of setup to do because the YNR changes haven't been merged yet - sorry :(

• Check out feat/update-party-importer
• Run the migrations
• Run python manage.py parties_import_from_ec
• Run runserver 4444 - this must stay running for the duration of your local testing!

Pre-test - WCIVF

• Check out this branch (feature/party-pages-update)
• In base.py, change YNR_BASE to http://0.0.0.0:4444
• Run the migrations
• Run python manage.py import_parties
• runserver

Test 1: Footer

• Criteria: A link in the footer exists which takes you to /parties/
• Open any page
• Scroll down to the footer
• There should be a link for All Parties
• Click the link
• Link takes you to http://localhost:8000/parties/

Test 2: Alternative name

• Criteria: Where a party has an alternative name, it is shown near the top of the page and is included as the first ballot description.
• Suggested party: http://localhost:8000/parties/party:53/labour-party
• Go to the page of a party with an alternative name
• You should see something like this, with the alternative name under the main header

• Scroll down to Ballot Descriptions
• The top bullet point in this section should be {party name} | {alternative_name} as in this screenshot

Test 3: Descriptions

• Criteria: Parties with no active descriptions and no registered alternative name should show "This party has no current alternative descriptions registered with the Electoral Commission.", parties with inactive descriptions should have a "Previous Descriptions" detail view
• Suggested party: http://localhost:8000/parties/party:2302/
• Go to the page of a party with inactive descriptions
• Scroll down to Ballot Descriptions
• You should see a detail view, titled Previous Descriptions, as in the screenshot below

• Find a party who has no alternative name and no active descriptions
• You should see "This party has no current alternative descriptions registered with the Electoral Commission.", as in the screenshot above.

Test 4: Emblems

• Criteria: Parties with no active emblems should show "This party has no current alternative emblems registered with the Electoral Commission.", parties with inactive emblems should have a "Previous Emblems" detail view
• Suggested party: http://localhost:8000/parties/party:7947/
• Go to the page of a party with inactive emblems
• Scroll down to Emblems
• You should see a detail view, titled Previous Emblems as in the screenshot below

• Find a party with no active emblems
• You should see "This party has no current alternative emblems registered with the Electoral Commission.", as in the screenshot above

Tasks

Preview Give feedback

We're having trouble rendering your tasklist, it's most likely has one of the following formatting errors:

• indented tasks (i.e. nested tasklist; support for this is coming!)
• an empty task (i.e. - [ ] on a line by itself)
• any empty new lines (before/after the tasklist or in between tasks)
• duplicate issue/pr links
• a draft task exceeds 512 characters

Please check the tasklists documentation for more information. 🔗 Feedback Discussion

Thank you for participating in the Private Beta ❤️

No tasks being tracked yet.

[coveralls]

coverage: 58.959% (+0.2%) from 58.803% when pulling fe24b46 on feature/party-pages-update into e7e9f67 on master.

[pmk01]

The only thing which has just occurred to me (sorry) is the 'this party is on the Great Britain register' line. I think we wanted to change/clarify that, either to explain what the register is, or perhaps more straightforwardly 'this party is registered to stand candidates in England, Scotland and Wales' (delete as applicable). If that's too much work though happy to deploy as is.

[VirginiaDooley]

This worked exactly as described and expected. The only difference was that I needed to add this setting to local.py instead of base.py in the setup to test:

Pre-test - WCIVF
Check out this branch (feature/party-pages-update)
In local.py, change YNR_BASE to http://0.0.0.0:4444