Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/minor text changes #1594

Merged
merged 3 commits into from
May 15, 2023
Merged

Hotfix/minor text changes #1594

merged 3 commits into from
May 15, 2023

Conversation

Bekabyx
Copy link
Contributor

@Bekabyx Bekabyx commented May 11, 2023

Closes #1280

As well as the above issue, I also looked at the inconsistency of bold text on our "you have x votes" sentences which Peter and I decided should probably just be bold in every case.

Also, I've dragged our translation file back up to date.

Fix 1, the boldening:

Before

Screenshot 2023-05-11 at 15 16 19

After (inconsistency in the figures is from my slightly outdated local db)

Screenshot 2023-05-11 at 15 16 13

To test this:

  • Go to the elections page for any upcoming, locked election. I was running with local.mid-ulster.moyola.2023-05-18
  • The numbers of candidates/votes/seats should be in bold per the screenshot

Fix 2, tenses:

This issue was caused by incorrect object referencing - we were assuming we were handling a postelection object but actually it was just an election object.

Before

Screenshot 2023-05-11 at 15 39 34

After

Screenshot 2023-05-11 at 15 39 21

To test this:

  • Via the elections page, go to any past election
  • The text should read "This election was held on..."
  • Returning to the elections page, go to any future election
  • The text should read "This election will be held on..."

Tasks

Preview Give feedback

@Bekabyx Bekabyx requested a review from VirginiaDooley May 11, 2023 15:14
Copy link
Contributor

@VirginiaDooley VirginiaDooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@Bekabyx Bekabyx merged commit f9bfdd9 into master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'will be held': past/present tense on top-level ID
2 participants