Merge pull request #2117 from DemocracyClub/remove-get_voter_id_reqs

remove get_voter_id_requirements property

wcivf/apps/api/views.py

@@ -96,7 +96,7 @@ def list(self, request, *args, **kwargs):
                 "voting_system": VotingSystemSerializer(
                     postelection.voting_system
                 ).data,
-                "requires_voter_id": postelection.get_voter_id_requirements,
+                "requires_voter_id": postelection.requires_voter_id,
                 "postal_voting_requirements": postelection.get_postal_voting_requirements,
                 "seats_contested": postelection.winner_count,
                 "organisation_type": postelection.post.organization_type,

wcivf/apps/elections/models.py

@@ -16,7 +16,6 @@
 from django.utils.translation import gettext_lazy as _
 from django_extensions.db.models import TimeStampedModel
 from uk_election_ids.metadata_tools import (
-    IDRequirementsMatcher,
     PostalVotingRequirementsMatcher,
 )
 
@@ -712,16 +711,6 @@ def should_show_candidates(self):
             return False
         return True
 
-    @property
-    def get_voter_id_requirements(self):
-        try:
-            matcher = IDRequirementsMatcher(
-                self.ballot_paper_id, nation=self.post.territory
-            )
-            return matcher.get_id_requirements()
-        except Exception:
-            return None
-
     @property
     def get_postal_voting_requirements(self):
         try:

wcivf/apps/elections/tests/test_models.py

@@ -456,10 +456,8 @@ def test_short_cancelled_message_html(self, post_election):
 
     def test_metadata_tools(self, db):
         old_ballot = PostElectionFactory()
-        assert old_ballot.get_voter_id_requirements is None
         assert old_ballot.get_postal_voting_requirements == "RPA2000"
 
         newer_ballot = PostElectionFactory()
         newer_ballot.ballot_paper_id = "parl.place.2025-01-01"
-        assert newer_ballot.get_voter_id_requirements == "EA-2022"
         assert newer_ballot.get_postal_voting_requirements == "EA-2022"