Skip to content

Commit

Permalink
Tidy up
Browse files Browse the repository at this point in the history
  • Loading branch information
VirginiaDooley committed Mar 5, 2021
1 parent 0c621cd commit 81ed4d1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 11 deletions.
9 changes: 2 additions & 7 deletions wcivf/apps/people/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,7 @@ def facebook_personal_username(self):
def facebook_username(self):
facebook_page_url = self.facebook_page_url
facebook_split = list(filter(None, facebook_page_url.split("/")))
facebook_username = facebook_split[-1]

return facebook_username
return facebook_split[-1]

@property
def instagram_username(self):
Expand Down Expand Up @@ -218,10 +216,7 @@ def statement_remainder(self):

@property
def display_deceased(self):
if self.death_date and self.current_or_future_candidacies:
return True
else:
return False
return self.death_date and self.current_or_future_candidacies

@cached_property
def current_or_future_candidacies(self):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
<h2 class="ds-candidate-name ds-h3">
About {{ object.name }}
</h2>
{% if object.cv %}
<p>
{% if object.cv %}
<h3>CV</h3>
<p>{{ object.cv }}</p>
{% endif %}
Expand All @@ -28,7 +28,7 @@ <h3>Associated companies</h3>
{{ company.role }}{% if company.role_status %}({{ company.role_status }}){% endif %}
{{ company.role_appointed_date | date:"Y" }} &ndash; {{ company.role_resigned_date | date:"Y"}}

<a href="https://beta.companieshouse.gov.uk/company/{{ company.company_number }}/">#}
<a href="https://beta.companieshouse.gov.uk/company/{{ company.company_number }}/">
More details from Companies House}
</a>
</li>
Expand Down
2 changes: 0 additions & 2 deletions wcivf/apps/people/templates/people/person_detail.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
{% include "elections/includes/_postcode_search_form.html" %}
{% endif %}

{#{% include "feedback/feedback_form.html" %}#}

</div>
</div>
</div>
Expand Down

0 comments on commit 81ed4d1

Please sign in to comment.