Check for trailing slash before setting username

DemocracyClub · Jun 21, 2024 · 776b2c7 · 776b2c7
1 parent 1a99e5e
commit 776b2c7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/wcivf/apps/people/models.py b/wcivf/apps/people/models.py
@@ -285,7 +285,11 @@ def instagram_username(self):
     @property
     def linkedin_username(self):
         linkedin_url = self.linkedin_url
-        return urlparse(linkedin_url).path.split("/")[-2]
+        # sometimes the url will have a trailing slash and othertimes it won't
+        # so we need to check for the trailing slash if it exists
+        if linkedin_url[-1] == "/":
+            return urlparse(linkedin_url).path.split("/")[-2]
+        return urlparse(linkedin_url).path.split("/")[-1]
 
     @property
     def youtube_username(self):

diff --git a/wcivf/apps/people/tests/test_person_models.py b/wcivf/apps/people/tests/test_person_models.py
@@ -52,7 +52,7 @@ def test_instagram_username(self):
         assert self.person.instagram_username == "vickyfordmp"
 
     def test_linkedin_username(self):
-        self.person.linkedin_url = "https://www.linkedin.com/in/vicky-ford/"
+        self.person.linkedin_url = "https://www.linkedin.com/in/vicky-ford"
         assert self.person.linkedin_username == "vicky-ford"
 
     def test_youtube_username(self):