Add deselected to API response

DemocracyClub · Feb 28, 2024 · 74a0a81 · 74a0a81
1 parent f9d1978
commit 74a0a81
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/wcivf/apps/api/serializers.py b/wcivf/apps/api/serializers.py
@@ -10,9 +10,7 @@ class PersonSerializer(serializers.ModelSerializer):
 
     def get_absolute_url(self, obj):
         if "request" in self.context:
-            return self.context["request"].build_absolute_uri(
-                obj.get_absolute_url()
-            )
+            return self.context["request"].build_absolute_uri(obj.get_absolute_url())
         return obj.get_absolute_url()
 
     class Meta:
@@ -49,14 +47,21 @@ class Meta:
             "party",
             "person",
             "previous_party_affiliations",
+            "deselected",
+            "deselected_source",
         )
 
     person = PersonSerializer(many=False, read_only=True)
     party = PartySerializer(many=False, read_only=True)
     list_position = serializers.SerializerMethodField(allow_null=True)
-    previous_party_affiliations = serializers.SerializerMethodField(
-        allow_null=True
-    )
+    previous_party_affiliations = serializers.SerializerMethodField(allow_null=True)
+
+    def to_representation(self, instance):
+        ret = super().to_representation(instance)
+        if not ret["deselected"]:
+            del ret["deselected"]
+            del ret["deselected_source"]
+        return ret
 
     def get_list_position(self, obj):
         """

diff --git a/wcivf/apps/people/tests/test_person_views.py b/wcivf/apps/people/tests/test_person_views.py
@@ -587,6 +587,15 @@ def test_deselected(self):
         )
         self.assertContains(response, "www.candidate-party-page.co.uk")
 
+        response = self.client.get(
+            f"/api/candidates_for_ballots/?ballot_ids=parl.place-name-2.2015-05-07"
+        )
+        self.assertTrue(response.json()[0]["candidates"][0]["deselected"])
+        self.assertEqual(
+            response.json()[0]["candidates"][0]["deselected_source"],
+            "www.candidate-party-page.co.uk",
+        )
+
 
 class TestPersonViewUnitTests:
     @pytest.fixture