Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DC Utils to fix 500 page #890

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Bump DC Utils to fix 500 page #890

merged 1 commit into from
Nov 6, 2024

Conversation

symroe
Copy link
Member

@symroe symroe commented Nov 5, 2024

Confirmed to be working locally, showing the expected page

image

@symroe symroe requested a review from chris48s November 5, 2024 12:38
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (e7d1cec) to head (d3b41b5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   77.73%   77.73%           
=======================================
  Files          28       28           
  Lines         566      566           
=======================================
  Hits          440      440           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chris48s
Copy link
Member

chris48s commented Nov 5, 2024

Yeah I just had a look at this locally.
Looks like the thing that was breaking it was the line {% extends "dc_base_naked.html" %} in the (package) 500 template, which you removed in DemocracyClub/dc_django_utils#92 👍
So just upgrading the package should fix this everywhere (or at least all the places we're setting up a handler500 )

@symroe
Copy link
Member Author

symroe commented Nov 5, 2024

I'm leaving this until #889 is merged: I want to test that the grep doesn't fail on a later PR

Confirmed to be working locally, showing the expected page
@symroe symroe force-pushed the use-dc-utils-500-pages branch from 3a70726 to b01af6d Compare November 6, 2024 18:03
@symroe symroe merged commit bb5a68d into master Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants