Issue #737 Add PR template #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manangka
requested changes
Jan 19, 2024
JoerivanEngelen
changed the title
Manangka
approved these changes
Jan 19, 2024
luitjansl
approved these changes
Jan 22, 2024
Contributor
luitjansl
left a comment
luitjansl
left a comment
There was a problem hiding this comment.
looks good ( 1 question)
| @@ -0,0 +1,20 @@ | |||
| Fixes # | |||
Contributor
There was a problem hiding this comment.
what is this line for? ( Fixes #)
Contributor
Author
There was a problem hiding this comment.
This presumably automatically adds the issue number (see Ribasim library)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #737
This PR adds a template for PRs. Unfortunately the template only works if it is in the default branch, (
master) in our case, so I could not test it. I presume it works though, as it works for Ribasim.Relevant docs