Skip to content

Issue #1548 fix performance ipf many wells #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 10, 2025

Conversation

JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Jun 4, 2025

Fixes #1548

Description

  • Fix issue with poor performance GridAgnosticWell.from_imod5_data when there are >10K wells in an IPF by moving an index explicitly beforehand. This requires one loop over all well groups, after which we can just use pandas/xarray functionality to do reqruired data transformations.
  • Properly type annotate helper functions in imod.mf6.wel that accept a sequence of pandas groupby objects.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

@JoerivanEngelen JoerivanEngelen requested a review from verkaik June 4, 2025 16:50
Copy link

@JoerivanEngelen JoerivanEngelen added this pull request to the merge queue Jun 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 10, 2025
@JoerivanEngelen JoerivanEngelen merged commit df307c9 into master Jun 10, 2025
7 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1548_fix_performance_IPF_many_wells branch June 10, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor performance when importing iMOD project file with IPF files having many wells
2 participants