Issue #1222 validation context #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defaults accordingly
JoerivanEngelen
changed the base branch from
master
to
imod5_converter_feature_branch
|
Manangka
approved these changes
Sep 18, 2024
Collaborator
Manangka
left a comment
Manangka
left a comment
There was a problem hiding this comment.
This cleans things up neatly!
| use_absolute_paths: bool = False | ||
| write_directory: Path = None # type: ignore | ||
|
|
||
| def __post_init__(self): |
Collaborator
There was a problem hiding this comment.
Nice. Didn't know about this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1222
Description
ValidationContextdataclass_validation_contextattribute toModflow6Simulation; this replaces the_is_from_imod5attribute.ValidationContextcontains an attribute for strict well checks, turned on by default. This is set to False when callingfrom_imod5or for split simulations._to_mf6_pkgmethod in a similar design as proposed in RemoveWriteContextfrom public API #1223, this to preserve public API.WriteContext, to make it a dataclass again. I had to ignore type annotation forwrite_directory, otherwise MyPy would throw errors. The whole property shebang presumably started with MyPy throwing errors. Reverting it back to a dataclass reduces the lines of code considerably, which makes it more maintainable.Checklist
Issue #nr, e.g.Issue #737