Issue #1176 assign wells with point filters #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manangka
requested changes
Sep 5, 2024
Fixes # 1179 # Description <!--- Thanks for opening a PR! Please add your description here of changes made and how they are going to resolve the linked issue --> # Checklist <!--- Before requesting review, please go through this checklist: --> - [ ] Links to correct issue - [ ] Update changelog, if changes affect users - [ ] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [ ] Unit tests were added - [ ] **If feature added**: Added/extended example
…_wells_zero_filter_length
|
The request for type hints lead to some extra required type annotations to be implemented for MyPy. A no-regret, with the slight downside that this changeset now influences more places of the code. |
…1191) Fixes #1190 # Description The TeamCity buildserver has some quirks making it sometimes hard to reproduce failing tests/build steps locally. In this PR this issue addressed by running the pipeline scripts in docker containers. These docker containers can be run locally as well, making it possible for the developer to reproduce the failing build on their own machine. # Checklist <!--- Before requesting review, please go through this checklist: --> - [x] Links to correct issue - [ ] Update changelog, if changes affect users - [ ] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [ ] Unit tests were added - [ ] **If feature added**: Added/extended example
Manangka
approved these changes
Sep 9, 2024
|
JoerivanEngelen
merged commit fa2fcfc
into
imod5_converter_feature_branch
5 of 6 checks passed
JoerivanEngelen
deleted the
issue_#1176_assign_wells_zero_filter_length
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1176
Description
Checklist
Issue #nr, e.g.Issue #737