Issue #1064 wel from imod #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to issue_#1064_wel_from_imod
luitjansl
requested review from
JoerivanEngelen,
Manangka and
HendrikKok
and removed request for
Manangka
JoerivanEngelen
requested changes
Jun 11, 2024
imod/mf6/wel.py
Outdated
Comment on lines
620
to
624
| wel_x = cls.panda_column_to_scalar(imod5_data[key]["dataframe"]["x"]) | ||
| wel_y = cls.panda_column_to_scalar(imod5_data[key]["dataframe"]["y"]) | ||
| wel_top = cls.panda_column_to_scalar(imod5_data[key]["dataframe"]["filt_top"]) | ||
| wel_bot = cls.panda_column_to_scalar(imod5_data[key]["dataframe"]["filt_bot"]) | ||
| rate = imod5_data[key]["dataframe"]["rate"] |
There was a problem hiding this comment.
I don't think the right thing happens here:
x, y, filt_top, and filt_bot can all be arrays. If wells are transient, a transient rate has to be generated with dimensions ("time", "index").
Wells at multiple locations can be part of one Well package.
There was a problem hiding this comment.
now reworked the PR to account for different wells in the same well package
imod/mf6/wel.py
Outdated
Comment on lines
644
to
651
| def panda_column_to_scalar(cls, column: pd.Series) -> float: | ||
| # input is a column of a pandas dataframe expected to contain the same value | ||
| # in every row (like the x-coordinate of a well) | ||
| # This function returns that value and checks they are all the same | ||
|
|
||
| if not np.all(column == column[0]): | ||
| raise ValueError("error while converting pandas column to scalar") | ||
| return float(column[0]) |
There was a problem hiding this comment.
This shouldn't be necessary
There was a problem hiding this comment.
removed this function
JoerivanEngelen
approved these changes
Jun 26, 2024
JoerivanEngelen
merged commit 879d521
into
imod5_converter_feature_branch
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1064
Description
Imports wells as grid-agnostic well packages, based on filter top and filter bottom, and x/y location as stated in the imod5_dataset object.
Checklist
Issue #nr, e.g.Issue #737