-
Notifications
You must be signed in to change notification settings - Fork 30
Sediment code cleanup #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Wflow/src/Wflow.jl
Outdated
| const VERSION = | ||
| VersionNumber(TOML.parsefile(joinpath(@__DIR__, "..", "Project.toml"))["version"]) | ||
|
|
||
| g_gravity = 9.81 # m s⁻² |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will produce better code if this is marked as const. Not aware of plans to run Wflow on other planets, otherwise g_gravity::Float64 = 9.81 will also get most benefits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see you are turning into a proper earth scientist.

Issue addressed
Fixes #745, split out from #735.
Explanation
Some of the changes include:
cbrt(x)instead ofx^0.33(which leads to some small changes in the results)amountfields to more explanatory names@teststatementsChecklist
master