Line breaks in string literal

[martin-honnen]

While playing with the XPath notebook I found that a sample like

let $xml1 := parse-xml('<root>
  <item>a</item>
  <item>b</item>
</root>')
return $xml1/root/item

runs fine but syntax errors are displayed for the second, third line and fourth line: "unexpected token".
That raises the question whether line breaks in XPath string literals are allowed, I think they are allowed.

[pgfearo]

Thanks for reporting this bug. Before actually looking at the code my feeling is that this is related to the fact that the problem reporter uses the same tokens as the 'semantic highlighter'. In VSCode, semantic highlighter tokens must be split to prevent a token spanning more than one line, I'm guessing the problem reporter isn't taking this token splitting into account . I'll report back once I've learned more.

…

On Sun, 19 Dec 2021, 16:00 martin-honnen, ***@***.***> wrote: While playing with the XPath notebook I found that a sample like let $xml1 := parse-xml('<root> <item>a</item> <item>b</item> </root>') return $xml1/root/item runs fine but syntax errors are displayed for the second, third line and fourth line: "unexpected token". That raises the question whether line breaks in XPath string literals are allowed, I think they are allowed. — Reply to this email directly, view it on GitHub <#6>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAU3RGR6R2XE45EVEXTI7B3URX6QRANCNFSM5KMAYBOQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[pgfearo]

The root cause of this is that there is code that doesn't handle multi-line string tokens that must be split so there is just one token per line. The affected code is actually in the lexer and diagnostics features in our XSLT/XPath extension that the XPath Notebook extension uses.

Please track progress on this at: vscode-xslt-tokenizer #92