Add Module::write options
#443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuliano-macedo
force-pushed
the
added-module-write-options
branch
from
3336b7c to
771dba5
Compare
giuliano-macedo
changed the title
Module::write optionsModule::write options
giuliano-macedo
force-pushed
the
added-module-write-options
branch
4 times, most recently
from
f58b9c2 to
5050890
Compare
giuliano-macedo
force-pushed
the
added-module-write-options
branch
from
5050890 to
c621681
Compare
DelSkayn
approved these changes
Mar 26, 2025
Owner
DelSkayn
left a comment
DelSkayn
left a comment
There was a problem hiding this comment.
Looks good, thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
WriteOptionsstruct that represents all flags that can be passed toqjs::JS_WriteObject, this is useful specially for the flagsJS_WRITE_OBJ_STRIP_SOURCEandJS_WRITE_OBJ_STRIP_DEBUGwhich when enabled decreases the bytecode size significantly (see quickjs-ng/quickjs#388), while adding it I've noticed two other flags (JS_WRITE_OBJ_REFERENCEandJS_WRITE_OBJ_SAB) that can be passed to it, so I've added as well (ref).