New release 1.10 contains a lot of build issues

[lublak]

I updated to the latest version, but now i get a lot of build issues:

error[E0080]: evaluation of constant value failed
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:215:35
    |
215 |     ["Size of JSMallocFunctions"][::core::mem::size_of::<JSMallocFunctions>() - 40usize];
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `20_usize - 40_usize`, which would overflow

error[E0080]: evaluation of constant value failed
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:677:38
    |
677 |     ["Size of JSClassExoticMethods"][::core::mem::size_of::<JSClassExoticMethods>() - 56usize];
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `28_usize - 56_usize`, which would overflow

error[E0080]: evaluation of constant value failed
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:720:28
    |
720 |     ["Size of JSClassDef"][::core::mem::size_of::<JSClassDef>() - 40usize];
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `20_usize - 40_usize`, which would overflow

error[E0080]: evaluation of constant value failed
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:741:31
    |
741 |     ["Size of JSEvalOptions"][::core::mem::size_of::<JSEvalOptions>() - 24usize];
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `16_usize - 24_usize`, which would overflow

error[E0080]: evaluation of constant value failed
    --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:1407:10
     |
1407 |         [::core::mem::size_of::<JSSharedArrayBufferFunctions>() - 32usize];
     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `16_usize - 32_usize`, which would overflow

error[E0080]: evaluation of constant value failed
    --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:1573:26
     |
1573 |     ["Size of JSSABTab"][::core::mem::size_of::<JSSABTab>() - 16usize];
     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `8_usize - 16_usize`, which would overflow

error[E0080]: evaluation of constant value failed
    --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:1705:33
     |
1705 |     ["Size of JSCFunctionType"][::core::mem::size_of::<JSCFunctionType>() - 8usize];
     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `4_usize - 8_usize`, which would overflow

error[E0080]: evaluation of constant value failed
    --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:1809:10
     |
1809 |         [::core::mem::size_of::<JSCFunctionListEntry__bindgen_ty_1__bindgen_ty_1>() - 16usize];
     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `8_usize - 16_usize`, which would overflow

error[E0080]: evaluation of constant value failed
    --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:1832:10
     |
1832 |         [::core::mem::size_of::<JSCFunctionListEntry__bindgen_ty_1__bindgen_ty_2>() - 16usize];
     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `8_usize - 16_usize`, which would overflow

error[E0080]: evaluation of constant value failed
    --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:1849:10
     |
1849 |         [::core::mem::size_of::<JSCFunctionListEntry__bindgen_ty_1__bindgen_ty_3>() - 16usize];
     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `8_usize - 16_usize`, which would overflow

error[E0080]: evaluation of constant value failed
    --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:1866:10
     |
1866 |         [::core::mem::size_of::<JSCFunctionListEntry__bindgen_ty_1__bindgen_ty_4>() - 16usize];
     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `8_usize - 16_usize`, which would overflow

error[E0080]: evaluation of constant value failed
    --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:1877:10
     |
1877 |         [::core::mem::size_of::<JSCFunctionListEntry__bindgen_ty_1>() - 16usize];
     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `8_usize - 16_usize`, which would overflow

error[E0080]: evaluation of constant value failed
    --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:1901:38
     |
1901 |     ["Size of JSCFunctionListEntry"][::core::mem::size_of::<JSCFunctionListEntry>() - 32usize];
     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `16_usize - 32_usize`, which would overflow

error[E0605]: non-primitive cast: `i64` as `JSValue`
  --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:53:5
   |
53 |     (0x7ff8000000000000i64 - ((JS_FLOAT64_TAG_ADDEND as i64) << 32)) as JSValue;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object

error[E0308]: mismatched types
  --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:23:5
   |
22 | pub const fn JS_MKVAL(tag: i32, val: i32) -> JSValue {
   |                                              ------- expected `JSValue` because of return type
23 |     ((tag as u64) << 32) | (val as u32 as u64)
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `JSValue`, found `u64`

error[E0369]: no implementation for `JSValue >> {integer}`
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:3:8
    |
3   |     (v >> 32) as _
    |      - ^^ -- {integer}
    |      |
    |      JSValue
    |
note: an implementation of `Shr<{integer}>` might be missing for `JSValue`
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:146:1
    |
146 | pub struct JSValue {
    | ^^^^^^^^^^^^^^^^^^ must implement `Shr<{integer}>`
note: the trait `Shr` must be implemented
   --> /home/*****/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/bit.rs:561:1
    |
561 | pub trait Shr<Rhs = Self> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0605]: non-primitive cast: `JSValue` as `i32`
 --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:8:5
  |
8 |     v as i32
  |     ^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object

error[E0605]: non-primitive cast: `JSValue` as `i32`
  --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:13:5
   |
13 |     v as i32 != 0
   |     ^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object

error[E0605]: non-primitive cast: `JSValue` as `isize`
  --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:18:5
   |
18 |     v as isize as *mut c_void
   |     ^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object

error[E0308]: mismatched types
  --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:28:5
   |
27 | pub fn JS_MKPTR(tag: i32, ptr: *mut c_void) -> JSValue {
   |                                                ------- expected `JSValue` because of return type
28 |     ((tag as u64) << 32) | (ptr as usize as u64)
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `JSValue`, found `u64`

error[E0599]: no method named `wrapping_add` found for struct `JSValue` in the current scope
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:47:14
    |
47  |         v: v.wrapping_add((JS_FLOAT64_TAG_ADDEND as u64) << 32),
    |              ^^^^^^^^^^^^ method not found in `JSValue`
    |
   ::: /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:146:1
    |
146 | pub struct JSValue {
    | ------------------ method `wrapping_add` not found for this struct

error[E0369]: no implementation for `JSValue & {integer}`
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:71:17
    |
71  |         if (u.v & 0x7fffffffffffffff) > 0x7ff0000000000000 {
    |             --- ^ ------------------ {integer}
    |             |
    |             JSValue
    |
note: an implementation of `BitAnd<{integer}>` might be missing for `JSValue`
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:146:1
    |
146 | pub struct JSValue {
    | ^^^^^^^^^^^^^^^^^^ must implement `BitAnd<{integer}>`
note: the trait `BitAnd` must be implemented
   --> /home/*****/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/bit.rs:144:1
    |
144 | pub trait BitAnd<Rhs = Self> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0599]: no method named `wrapping_sub` found for struct `JSValue` in the current scope
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:74:17
    |
74  |             u.v.wrapping_sub((JS_FLOAT64_TAG_ADDEND as u64) << 32)
    |                 ^^^^^^^^^^^^ method not found in `JSValue`
    |
   ::: /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:146:1
    |
146 | pub struct JSValue {
    | ------------------ method `wrapping_sub` not found for this struct

error[E0369]: no implementation for `JSValue >> {integer}`
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/inlines/ptr_32_nan_boxing.rs:97:20
    |
97  |     tag == (JS_NAN >> 32) as i32
    |             ------ ^^ -- {integer}
    |             |
    |             JSValue
    |
note: an implementation of `Shr<{integer}>` might be missing for `JSValue`
   --> /home/*****/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rquickjs-sys-0.10.0/src/bindings/wasm32-wasip1.rs:146:1
    |
146 | pub struct JSValue {
    | ^^^^^^^^^^^^^^^^^^ must implement `Shr<{integer}>`
note: the trait `Shr` must be implemented
   --> /home/*****/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/bit.rs:561:1
    |
561 | pub trait Shr<Rhs = Self> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^

[Sytten]

Feel free to submit a PR, none of us use the wasm bindings

[lublak]

@Sytten some reads from myself:

Same issue should be on targets:

• aarch64-apple-darwin.rs
• aarch64-pc-windows-msvc.rs
• aarch64-unknown-linux-gnu.rs
• aarch64-unknown-linux-musl.rs
• loongarch64-unknown-linux-gnu.rs
• loongarch64-unknown-linux-musl.rs
• wasm32-wasip1.rs
• wasm32-wasip2.rs
• x86_64-apple-darwin.rs
• x86_64-pc-windows-gnu.rs
• x86_64-pc-windows-msvc.rs
• x86_64-unknown-linux-gnu.rs

how are the bindings are generated?

as an example from :sys/src/bindings/i686-unknown-linux-gnu.rs

pub type JSValue = u64;

the others: the shift error (u64 can shifted but now its a struct on a lot of bindings)

#[repr(C)]
#[derive(Copy, Clone)]
pub struct JSValue {
    pub u: JSValueUnion,
    pub tag: i64,
}

same for the other issue:

incorret:

#[allow(clippy::unnecessary_operation, clippy::identity_op)]
const _: () = {
    ["Size of JSMallocFunctions"][::core::mem::size_of::<JSMallocFunctions>() - 40usize];
    ["Alignment of JSMallocFunctions"][::core::mem::align_of::<JSMallocFunctions>() - 8usize];
    ["Offset of field: JSMallocFunctions::js_calloc"]
        [::core::mem::offset_of!(JSMallocFunctions, js_calloc) - 0usize];
    ["Offset of field: JSMallocFunctions::js_malloc"]
        [::core::mem::offset_of!(JSMallocFunctions, js_malloc) - 8usize];
    ["Offset of field: JSMallocFunctions::js_free"]
        [::core::mem::offset_of!(JSMallocFunctions, js_free) - 16usize];
    ["Offset of field: JSMallocFunctions::js_realloc"]
        [::core::mem::offset_of!(JSMallocFunctions, js_realloc) - 24usize];
    ["Offset of field: JSMallocFunctions::js_malloc_usable_size"]
        [::core::mem::offset_of!(JSMallocFunctions, js_malloc_usable_size) - 32usize];
};

correct:

#[allow(clippy::unnecessary_operation, clippy::identity_op)]
const _: () = {
    ["Size of JSMallocFunctions"][::core::mem::size_of::<JSMallocFunctions>() - 20usize];
    ["Alignment of JSMallocFunctions"][::core::mem::align_of::<JSMallocFunctions>() - 4usize];
    ["Offset of field: JSMallocFunctions::js_calloc"]
        [::core::mem::offset_of!(JSMallocFunctions, js_calloc) - 0usize];
    ["Offset of field: JSMallocFunctions::js_malloc"]
        [::core::mem::offset_of!(JSMallocFunctions, js_malloc) - 4usize];
    ["Offset of field: JSMallocFunctions::js_free"]
        [::core::mem::offset_of!(JSMallocFunctions, js_free) - 8usize];
    ["Offset of field: JSMallocFunctions::js_realloc"]
        [::core::mem::offset_of!(JSMallocFunctions, js_realloc) - 12usize];
    ["Offset of field: JSMallocFunctions::js_malloc_usable_size"]
        [::core::mem::offset_of!(JSMallocFunctions, js_malloc_usable_size) - 16usize];
};

[lublak]

i think this pull request will fix this issue: #526

btw there are still some missing targets in this pull request
myself the wasm is include which will fix my issue. It could be still the same issue on the other targets i listed.

[lublak]

@Syttenis there an eta when the wasip1 binding will be released? (i created a pull request which is also merged)

[richarddd]

@Sytten we should draft a new release this week!

[Sytten]

Bump minor or patch?

[richarddd]

Bump minor or patch?

Minor for sure