Skip to content

Conversation

@jaissica12
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 26, 2026

@jaissica12 Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74401,
  "author": "jaissica12",
  "headCommitOid": "20614c753e5ceb9f058396bf99663310d48a16c6",
  "mergeBaseOid": "573431492950d73a526b016867cda4fc13a4248e",
  "lastPushDate": "2026-01-26T16:13:54.000Z",
  "lastActivityDate": "2026-01-28T21:39:54.000Z",
  "mergeOfferDate": "2026-01-28T21:38:28.000Z",
  "mergeRequestDate": "2026-01-28T21:39:54.000Z",
  "mergeRequestUser": "jaissica12",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "mparticle__web-sdk",
      "kind": "edit",
      "files": [
        {
          "path": "types/mparticle__web-sdk/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mparticle__web-sdk/test/mparticle__web-sdk-instance-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/mparticle__web-sdk/test/mparticle__web-sdk-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "asap",
        "rmi22186"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "alexs-mparticle",
      "date": "2026-01-28T21:37:47.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "rmi22186",
      "date": "2026-01-28T21:12:29.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3800429848,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @asap @rmi22186 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Jan 26, 2026
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 26, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Jan 26, 2026
@typescript-bot typescript-bot removed Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 27, 2026
@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Waiting for Code Reviews in Pull Request Status Board Jan 27, 2026
@typescript-bot
Copy link
Contributor

@rmi22186, @alexs-mparticle Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@jaissica12 jaissica12 requested a review from rmi22186 January 27, 2026 22:33
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 28, 2026
@typescript-bot
Copy link
Contributor

@jaissica12: Everything looks good here. I am ready to merge this PR (at 20614c7) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@asap, @rmi22186: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Jan 28, 2026
@jaissica12
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Jan 28, 2026
@typescript-bot typescript-bot merged commit ab0b2c6 into DefinitelyTyped:master Jan 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Other Approved This PR was reviewed and signed-off by a community member. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

4 participants