Skip to content

Conversation

hkleungai
Copy link
Contributor

Add identifierBase for .inc(). Resolves discussion #73405.

Add throwErrors for .parse().

Update some other jsdoc.


Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 5, 2025

@hkleungai Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73409,
  "author": "hkleungai",
  "headCommitOid": "b17198f998e7649b310603e20d74553a0af533d7",
  "mergeBaseOid": "68cfc5a271cd13cf509636f3f54e819bfe816112",
  "lastPushDate": "2025-08-05T05:56:05.000Z",
  "lastActivityDate": "2025-09-03T14:43:39.000Z",
  "mergeOfferDate": "2025-09-03T03:30:40.000Z",
  "mergeRequestDate": "2025-09-03T14:43:39.000Z",
  "mergeRequestUser": "hkleungai",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "semver",
      "kind": "edit",
      "files": [
        {
          "path": "types/semver/classes/semver.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/semver/functions/compare-loose.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/semver/functions/inc.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/semver/functions/parse.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/semver/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/semver/semver-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Bartvds",
        "BendingBender",
        "LucianBuzzo",
        "ajafff",
        "ExE-Boss",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2025-09-03T03:30:00.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "steveoh",
      "date": "2025-08-05T15:03:13.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3153453305,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @Bartvds @BendingBender @LucianBuzzo @ajafff @ExE-Boss @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Aug 5, 2025
@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Aug 5, 2025
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Aug 16, 2025
@typescript-bot
Copy link
Contributor

Re-ping @Bartvds, @BendingBender, @LucianBuzzo, @ajafff, @ExE-Boss, @peterblazejewicz:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews (Blessed) in Pull Request Status Board Aug 20, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews (Blessed) to Needs Maintainer Action in Pull Request Status Board Aug 23, 2025
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @hkleungai.

(Ping @Bartvds, @BendingBender, @LucianBuzzo, @ajafff, @ExE-Boss, @peterblazejewicz.)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Sep 3, 2025
@typescript-bot
Copy link
Contributor

@hkleungai: Everything looks good here. I am ready to merge this PR (at b17198f) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Bartvds, @BendingBender, @LucianBuzzo, @ajafff, @ExE-Boss, @peterblazejewicz: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Sep 3, 2025
@hkleungai
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Sep 3, 2025
@typescript-bot typescript-bot merged commit f68bc9a into DefinitelyTyped:master Sep 3, 2025
4 checks passed
@hkleungai hkleungai deleted the semver-update branch September 3, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants