-
Notifications
You must be signed in to change notification settings - Fork 30.5k
fix(node/http): Agent missing methods #73095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node/http): Agent missing methods #73095
Conversation
|
@bodinsamuel Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 73095,
"author": "bodinsamuel",
"headCommitOid": "32d4f26a2edd6b7b1725002393778bc8a231f3fe",
"mergeBaseOid": "e507b7a12247e581d58e1fa669d3c59835b30649",
"lastPushDate": "2025-06-24T08:54:38.000Z",
"lastActivityDate": "2025-06-28T07:21:59.000Z",
"mergeOfferDate": "2025-06-27T17:04:20.000Z",
"mergeRequestDate": "2025-06-28T07:21:59.000Z",
"mergeRequestUser": "bodinsamuel",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v18/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v20/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v22/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v22/test/http.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky",
"Renegade334"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sheetalkamat",
"date": "2025-06-27T17:03:42.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "Renegade334",
"date": "2025-06-24T16:36:31.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2999425154,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @Renegade334 — please review this PR in the next few days. Be sure to explicitly select |
Renegade334
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace these with the output from generate-docs – these are currently ill-formed.
|
@bodinsamuel One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
Thanks @Renegade334, should have addressed all your comments 🙏🏻 |
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Renegade334
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Merci !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory these should also go into the branches' own test/http.ts scripts, but it's not the end of the world.
|
@bodinsamuel One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
🤦🏻 sorry about that, fixed and added the tests on each version |
|
@bodinsamuel: Everything looks good here. I am ready to merge this PR (at 32d4f26) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky, @Renegade334: you can do this too.) |
|
Ready to merge |
Caused by a recent update of `@types/node` (see here DefinitelyTyped/DefinitelyTyped#73095). By implementing the missing methods (and wrapping other calls in `@ts-ignore`), this should fix the downstream build errors (e.g. [here](https://github.com/apify/crawlee/actions/runs/15988466886/job/45097154759#step:12:156)) Closes #163
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition: