Skip to content

Conversation

@bodinsamuel
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 24, 2025

@bodinsamuel Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73095,
  "author": "bodinsamuel",
  "headCommitOid": "32d4f26a2edd6b7b1725002393778bc8a231f3fe",
  "mergeBaseOid": "e507b7a12247e581d58e1fa669d3c59835b30649",
  "lastPushDate": "2025-06-24T08:54:38.000Z",
  "lastActivityDate": "2025-06-28T07:21:59.000Z",
  "mergeOfferDate": "2025-06-27T17:04:20.000Z",
  "mergeRequestDate": "2025-06-28T07:21:59.000Z",
  "mergeRequestUser": "bodinsamuel",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/http.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v18/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/test/http.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v20/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v20/test/http.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v22/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v22/test/http.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky",
        "Renegade334"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sheetalkamat",
      "date": "2025-06-27T17:03:42.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Renegade334",
      "date": "2025-06-24T16:36:31.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2999425154,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

@DangerBotOSS
Copy link

DangerBotOSS commented Jun 24, 2025

Formatting

The following files are not formatted:

  1. types/node/test/http.ts
  2. types/node/v20/test/http.ts
  3. types/node/v22/test/http.ts
  4. types/node/v18/test/http.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 32d4f26

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jun 24, 2025
Copy link
Contributor

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace these with the output from generate-docs – these are currently ill-formed.

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jun 24, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in Pull Request Status Board Jun 24, 2025
@typescript-bot
Copy link
Contributor

@bodinsamuel One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot removed the Revision needed This PR needs code changes before it can be merged. label Jun 24, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Jun 24, 2025
@typescript-bot typescript-bot added the Where is GH Actions? GH Actions didn't give a response to this PR label Jun 24, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Other in Pull Request Status Board Jun 24, 2025
@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label Jun 24, 2025
@typescript-bot typescript-bot moved this from Other to Waiting for Code Reviews in Pull Request Status Board Jun 24, 2025
@bodinsamuel bodinsamuel requested a review from Renegade334 June 24, 2025 13:03
@bodinsamuel
Copy link
Contributor Author

Thanks @Renegade334, should have addressed all your comments 🙏🏻

@typescript-bot
Copy link
Contributor

@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jun 24, 2025
Copy link
Contributor

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merci !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory these should also go into the branches' own test/http.ts scripts, but it's not the end of the world.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jun 24, 2025
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Owner Approved A listed owner of this package signed off on the pull request. labels Jun 24, 2025
@typescript-bot
Copy link
Contributor

@bodinsamuel One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in Pull Request Status Board Jun 24, 2025
@bodinsamuel
Copy link
Contributor Author

🤦🏻 sorry about that, fixed and added the tests on each version

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR and removed Revision needed This PR needs code changes before it can be merged. labels Jun 24, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Other in Pull Request Status Board Jun 24, 2025
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Where is GH Actions? GH Actions didn't give a response to this PR labels Jun 24, 2025
@typescript-bot typescript-bot moved this from Other to Waiting for Code Reviews in Pull Request Status Board Jun 24, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jun 24, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 27, 2025
@typescript-bot
Copy link
Contributor

@bodinsamuel: Everything looks good here. I am ready to merge this PR (at 32d4f26) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky, @Renegade334: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in Pull Request Status Board Jun 27, 2025
@bodinsamuel
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Jun 28, 2025
@typescript-bot typescript-bot merged commit 239534a into DefinitelyTyped:master Jun 28, 2025
15 checks passed
barjin added a commit to apify/got-scraping that referenced this pull request Jul 1, 2025
Caused by a recent update of `@types/node` (see here
DefinitelyTyped/DefinitelyTyped#73095). By
implementing the missing methods (and wrapping other calls in
`@ts-ignore`), this should fix the downstream build errors (e.g.
[here](https://github.com/apify/crawlee/actions/runs/15988466886/job/45097154759#step:12:156))

Closes #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants