Skip to content

fix(node/tls): fix context param in Server.addContext() #72507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hkleungai
Copy link
Contributor

@hkleungai hkleungai commented Apr 15, 2025

See PR nodejs/node#47570. The PR is released in v18.17.0, v20.1.0 as well.


Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 15, 2025

@hkleungai Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72507,
  "author": "hkleungai",
  "headCommitOid": "9eab4a7fb952bfa722e8e49972b6d970f4fe6df2",
  "mergeBaseOid": "3634b01d50c10ce1afaae63e41d39e7da309d8e3",
  "lastPushDate": "2025-04-15T11:20:58.000Z",
  "lastActivityDate": "2025-05-05T19:30:20.000Z",
  "mergeOfferDate": "2025-05-05T17:15:31.000Z",
  "mergeRequestDate": "2025-05-05T19:30:20.000Z",
  "mergeRequestUser": "hkleungai",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/test/tls.ts",
          "kind": "test"
        },
        {
          "path": "types/node/tls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/test/tls.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v18/tls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v20/test/tls.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v20/tls.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky",
        "Renegade334"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2025-05-05T17:14:52.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Renegade334",
      "date": "2025-04-25T20:17:16.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2804713768,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 15, 2025

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Apr 15, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Apr 15, 2025
@hkleungai hkleungai force-pushed the node-tls-fix-Server-addContext branch from d28f6ef to 9eab4a7 Compare April 25, 2025 14:56
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Apr 25, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Apr 25, 2025
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Apr 25, 2025
@typescript-bot
Copy link
Contributor

@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Maintainer Action in Pull Request Status Board May 3, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 5, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board May 5, 2025
@hkleungai
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board May 5, 2025
@typescript-bot typescript-bot merged commit 517caed into DefinitelyTyped:master May 5, 2025
15 checks passed
@hkleungai hkleungai deleted the node-tls-fix-Server-addContext branch May 5, 2025 19:33
@Paullht
Copy link

Paullht commented May 12, 2025

B3dF6KmEwZLtUSFBkvEv35qaSdo2hS3qsgM7yrQkLET

1 similar comment
@Paullht
Copy link

Paullht commented May 12, 2025

B3dF6KmEwZLtUSFBkvEv35qaSdo2hS3qsgM7yrQkLET

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants