-
Notifications
You must be signed in to change notification settings - Fork 30.5k
[vinyl][vinyl-file] Fix 5.5 nightly errors #69319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gabritto Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69319,
"author": "gabritto",
"headCommitOid": "f84a6cd4e48cdccbe0bd7b179001c79045cf1e1f",
"mergeBaseOid": "07c771f1e113e2ebcd6a88778555883f22166ab3",
"lastPushDate": "2024-04-10T03:13:42.000Z",
"lastActivityDate": "2024-04-15T18:21:25.000Z",
"mergeOfferDate": "2024-04-15T18:22:08.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "vinyl-file",
"kind": "edit",
"files": [
{
"path": "types/vinyl-file/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cleanchedFist"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "vinyl",
"kind": "edit",
"files": [
{
"path": "types/vinyl/index.d.ts",
"kind": "definition"
}
],
"owners": [
"vvakame",
"thorn0"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2024-04-15T18:21:25.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2046470556,
"ciResult": "pass"
} |
🔔 @cleanchedFist @vvakame @thorn0 — please review this PR in the next few days. Be sure to explicitly select |
@gabritto The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll merge soon unless I hear any objections from package owners.
microsoft/TypeScript#57341 got merged, which causes this library to have errors on the methods that override methods that have a
this is X
type predicate as return type.Similar to what TypeScript already did for non-
this
type predicates, a function or method is only assignable to another one that has athis
type predicate return type if it also has a type predicate return type. Example: