Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for tabulator-tables 5.6 #68882

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

mike-lischke
Copy link
Contributor

@mike-lischke mike-lischke commented Mar 4, 2024

Please fill in this template.

Select one of these and delete the others:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

This patch comes with a large number of changes, since a new main feature was added (range selection). The release notes contain a detailed description. Additional details can be found here.

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 4, 2024

@mike-lischke Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68882,
  "author": "mike-lischke",
  "headCommitOid": "05f88452d36263729f81eca38a6ec5377d0e63bd",
  "mergeBaseOid": "2617451394aff1a4f99f8df77b12c36b1c0a243e",
  "lastPushDate": "2024-03-04T15:54:11.000Z",
  "lastActivityDate": "2024-03-04T16:06:43.000Z",
  "mergeOfferDate": "2024-03-04T16:03:24.000Z",
  "mergeRequestDate": "2024-03-04T16:06:43.000Z",
  "mergeRequestUser": "mike-lischke",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "tabulator-tables",
      "kind": "edit",
      "files": [
        {
          "path": "types/tabulator-tables/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/tabulator-tables/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/tabulator-tables/tabulator-tables-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jojoshua",
        "mike-lischke"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Jojoshua",
      "date": "2024-03-04T16:03:11.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1976903527,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label Mar 4, 2024
@typescript-bot
Copy link
Contributor

🔔 @Jojoshua — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@Jojoshua
Copy link
Contributor

Jojoshua commented Mar 4, 2024

Good update!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 4, 2024
@typescript-bot
Copy link
Contributor

@mike-lischke: Everything looks good here. I am ready to merge this PR (at 05f8845) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Jojoshua: you can do this too.)

@mike-lischke
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit 0760c38 into DefinitelyTyped:master Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants