Skip to content

[react-redux] Replace usage of React's global JSX namespace with scoped JSX #67693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Dec 3, 2023

Was deprecated in #64464. Cherry-picked from #67588.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 3, 2023

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 67693,
  "author": "eps1lon",
  "headCommitOid": "6ded637e06bd59fb525eab12744e870055a5a5b9",
  "mergeBaseOid": "944a188a7545488b475c1568113e1c396a985fc1",
  "lastPushDate": "2023-12-03T16:59:05.000Z",
  "lastActivityDate": "2023-12-03T17:06:41.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react-redux",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-redux/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-redux/v5/react-redux-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-redux/v6/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tkqubo",
        "clayne11",
        "tansongyang",
        "nicholasboll",
        "mdibyo",
        "val1984",
        "jrakotoharisoa",
        "apapirovski",
        "surgeboris",
        "soerenbf",
        "mrwolfz",
        "dylanvann",
        "Lazyuki",
        "kazuma1989",
        "megazazik",
        "jun-sheaf",
        "phryneas",
        "markerikson"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "markerikson",
      "date": "2023-12-03T17:04:37.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1837538814,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @tkqubo @clayne11 @tansongyang @NicholasBoll @mDibyo @val1984 @jrakotoharisoa @apapirovski @surgeboris @soerenbf @MrWolfZ @DylanVann @Lazyuki @kazuma1989 @megazazik @jun-sheaf @phryneas @markerikson — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Formatting

The following files are not formatted:

  1. types/react-redux/index.d.ts
  2. types/react-redux/v6/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 6ded637

Copy link

@markerikson markerikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Note that we switched to our own TS build in React-Redux v8. Do we need to make any changes over there?

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Dec 3, 2023
@eps1lon
Copy link
Collaborator Author

eps1lon commented Dec 3, 2023

Do we need to make any changes over there?

The same ones, yes. Should be as simple as npx types-react-codemod@3.0.0 scoped-jsx ~/react-redux

markerikson added a commit to reduxjs/react-redux that referenced this pull request Dec 3, 2023
@eps1lon eps1lon merged commit 7aa743d into DefinitelyTyped:master Dec 4, 2023
@eps1lon eps1lon deleted the feat/deprecated-jsx/react-redux branch December 4, 2023 20:16
Bee1130 added a commit to Bee1130/React-Redux that referenced this pull request Jan 19, 2024
fairsky0201 added a commit to fairsky0201/react-redux that referenced this pull request Apr 17, 2024
pumatopdev added a commit to pumatopdev/react-redux that referenced this pull request Dec 9, 2024
wolf620 added a commit to wolf620/trustyHash that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants