[chai] add support for Set and Map to assert.lengthOf

[na-trium-144]

Documentation of chai says that I can check the size property of objects such as Set or Map with assert.lengthOf, but TypeScript gives error: Type 'Map<string, number>' has no properties in common with type '{ readonly length?: number | undefined; }'.
This PR fixes this error.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
  • The common mistakes section in readme suggests to run prettier, but I didn't because it produced diffs where I did not changed.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://www.chaijs.com/api/assert/#method_lengthof, .lengthOf for Maps and Sets chaijs/chai#1131
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@na-trium-144 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• chai — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66744,
  "author": "na-trium-144",
  "headCommitOid": "3f3b729d675692dae60c4eb6b723a022b32bf757",
  "mergeBaseOid": "6602670baf21cae33938757102eedc4ff6dbb3dc",
  "lastPushDate": "2023-09-19T07:34:58.000Z",
  "lastActivityDate": "2023-10-10T00:28:30.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2023-10-09T16:43:05.000Z",
  "mergeRequestDate": "2023-10-10T00:28:30.000Z",
  "mergeRequestUser": "na-trium-144",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "chai",
      "kind": "edit",
      "files": [
        {
          "path": "types/chai/chai-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/chai/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Bartvds",
        "AGBrown",
        "olivr70",
        "mwistrand",
        "shaunluttin",
        "micksatana",
        "ErikSchierboom",
        "bparan",
        "CXuesong",
        "joeykilpatrick"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-10-09T16:42:20.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1724980718,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @Bartvds @AGBrown @olivr70 @mwistrand @shaunluttin @micksatana @ErikSchierboom @bparan @CXuesong @joeykilpatrick — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

Re-ping @Bartvds, @AGBrown, @olivr70, @mwistrand, @shaunluttin, @micksatana, @ErikSchierboom, @bparan, @CXuesong, @joeykilpatrick:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @na-trium-144.

(Ping @Bartvds, @AGBrown, @olivr70, @mwistrand, @shaunluttin, @micksatana, @ErikSchierboom, @bparan, @CXuesong, @joeykilpatrick.)

[jakebailey]

This isn't a new problem, but I don't understand why this is a generic at all. It could just accept this constraint as the parameter type.

That and, this type technically accepts the literal {} as an argument, which feels wrong.

[typescript-bot]

@na-trium-144: Everything looks good here. I am ready to merge this PR (at 3f3b729) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Bartvds, @AGBrown, @olivr70, @mwistrand, @shaunluttin, @micksatana, @ErikSchierboom, @bparan, @CXuesong, @joeykilpatrick: you can do this too.)

[na-trium-144]

Ready to merge