Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memory-cache] Fix del sig, return boolean instead of void #65623

Conversation

thieman
Copy link
Contributor

@thieman thieman commented May 28, 2023

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Issue 65622

@typescript-bot
Copy link
Contributor

typescript-bot commented May 28, 2023

@thieman Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 65623,
  "author": "thieman",
  "headCommitOid": "40eac4351b03e7505c247b9c1dcdf84f49d96ce1",
  "mergeBaseOid": "1a5956fbfda99ad3392a1813bd0822d39c46585f",
  "lastPushDate": "2023-05-28T17:54:07.000Z",
  "lastActivityDate": "2023-06-15T22:17:55.000Z",
  "mergeOfferDate": "2023-06-15T20:35:24.000Z",
  "mergeRequestDate": "2023-06-15T22:17:55.000Z",
  "mergeRequestUser": "thieman",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "memory-cache",
      "kind": "edit",
      "files": [
        {
          "path": "types/memory-cache/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/memory-cache/memory-cache-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jedigo",
        "thieman"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2023-06-15T20:34:39.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Semigradsky",
      "date": "2023-06-12T16:02:55.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1566212694,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. labels May 28, 2023
@typescript-bot
Copy link
Contributor

🔔 @jedigo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Jun 8, 2023
@typescript-bot
Copy link
Contributor

Re-ping @jedigo:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Jun 12, 2023
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @thieman.

(Ping @jedigo.)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jun 15, 2023
@typescript-bot
Copy link
Contributor

@thieman: Everything looks good here. I am ready to merge this PR (at 40eac43) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jedigo: you can do this too.)

@thieman
Copy link
Contributor Author

thieman commented Jun 15, 2023

Ready to merge

@typescript-bot typescript-bot merged commit ae486db into DefinitelyTyped:master Jun 15, 2023
Desplandis pushed a commit to Desplandis/DefinitelyTyped that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants