Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic ESM instructions to README #64361

Merged
merged 2 commits into from
Feb 18, 2023
Merged

Add basic ESM instructions to README #64361

merged 2 commits into from
Feb 18, 2023

Conversation

sandersn
Copy link
Contributor

No description provided.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 14, 2023

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (README.md)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 64361,
  "author": "sandersn",
  "headCommitOid": "864c0d82e236bbf866773604a1277cfbe9fa7d2f",
  "mergeBaseOid": "0eee8339a68d5a198ad556f78832676d94f793ad",
  "lastPushDate": "2023-02-14T21:55:32.000Z",
  "lastActivityDate": "2023-02-14T22:43:11.000Z",
  "mergeOfferDate": "2023-02-14T22:43:54.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "README.md",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2023-02-14T22:43:11.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "BendingBender",
      "date": "2023-02-14T21:07:34.000Z",
      "abbrOid": "9b87a93"
    }
  ],
  "mainBotCommentID": 1430372929,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @sandersn — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Feb 14, 2023
@andrewbranch
Copy link
Member

Want to mention "exports" too? If the implementation package.json has "exports" with subpaths or conditions, the DT one should mirror that structure as well.

@typescript-bot typescript-bot removed the Other Approved This PR was reviewed and signed-off by a community member. label Feb 14, 2023
@typescript-bot
Copy link
Contributor

@BendingBender Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 14, 2023
@sandersn sandersn merged commit e307491 into master Feb 18, 2023
@sandersn sandersn deleted the add-ESM-to-README branch February 18, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants