Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(find-test-names): v1.16/v1.17 updates #59908

Merged

Conversation

peterblazejewicz
Copy link
Member

  • 'setEffectiveTags'
  • 'filterByEffectiveTags'

bahmutov/find-test-names@v1.14.1...v1.17.1

Thanks!

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Run npm test <package to test>.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 14, 2022

@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59908,
  "author": "peterblazejewicz",
  "headCommitOid": "e75a8d73d8d03ae4d0082519b520a534af0f9f72",
  "mergeBaseOid": "ad6017db2af916f936f2e712b4b1e31e6e9a62e6",
  "lastPushDate": "2022-04-14T20:35:20.000Z",
  "lastActivityDate": "2022-04-16T18:43:44.000Z",
  "mergeOfferDate": "2022-04-15T10:33:08.000Z",
  "mergeRequestDate": "2022-04-16T18:43:44.000Z",
  "mergeRequestUser": "peterblazejewicz",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "find-test-names",
      "kind": "edit",
      "files": [
        {
          "path": "types/find-test-names/find-test-names-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/find-test-names/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "joshuajeschek",
      "date": "2022-04-15T10:32:26.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1099625447,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. labels Apr 14, 2022
@typescript-bot
Copy link
Contributor

🔔 @peterblazejewicz — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

Copy link
Contributor

@joshuajeschek joshuajeschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 15, 2022
@typescript-bot
Copy link
Contributor

@peterblazejewicz: Everything looks good here. I am ready to merge this PR (at e75a8d7) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@peterblazejewicz
Copy link
Member Author

Ready to merge 💘

@typescript-bot typescript-bot merged commit ea8c24b into DefinitelyTyped:master Apr 16, 2022
@peterblazejewicz peterblazejewicz deleted the update/find-test-names branch April 16, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants