update(express-sitemap-xml): minor updates

[peterblazejewicz]

• mark properly buildSitemap as async
• amend tests
• ditch old TS requirements

Thanks!

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
• Run npm run lint package-name (or tsc if no tslint.json is present).
• Provide a URL to documentation or source code which provides context for the suggested changes
• Include tests for your changes

[typescript-bot]

@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• express-sitemap-xml on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 49572,
  "author": "peterblazejewicz",
  "headCommitAbbrOid": "f8b39fa",
  "headCommitOid": "f8b39fa69cc1844bb70775e38dbd70e5e66ed527",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-11-14T21:12:19.000Z",
  "lastCommentDate": "2020-11-14T21:30:54.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "express-sitemap-xml",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-sitemap-xml/express-sitemap-xml-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/express-sitemap-xml/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ffflorian",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ffflorian",
      "date": "2020-11-14T21:20:29.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @ffflorian — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[ffflorian]

Thanks!

[typescript-bot]

@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ffflorian: you can do this too.)

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#49572	diff
Batch compilation
Memory usage (MiB)	75.2	74.2	-1.3%
Type count	10094	10123	0%
Assignability cache size	1775	1783	0%
Language service
Samples taken	46	58	+26%
Identifiers in tests	46	58	+26%
getCompletionsAtPosition
Mean duration (ms)	418.1	410.2	-1.9%
Mean CV	13.5%	12.0%
Worst duration (ms)	489.7	518.0	+5.8%
Worst identifier	base	sitemap2
getQuickInfoAtPosition
Mean duration (ms)	416.2	413.4	-0.7%
Mean CV	12.7%	11.8%	-7.4%
Worst duration (ms)	526.1	500.5	-4.9%
Worst identifier	then	url

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[peterblazejewicz]

Ready to merge 💋

[typescript-bot]

I just published @types/express-sitemap-xml@1.1.1 to npm.