crypto.generateKeyPair('x25519') and crypto.diffieHellman({ privateKey, publicKey }) support

[fuzzc0re]

Part of #45614

• [x ] Use a meaningful title for the pull request. Include the name of the package modified.
• [x ] Test the change in your own code. (Compile and run.)

If changing an existing definition:

• [x ] Provide a URL to documentation or source code which provides context for the suggested changes:
  https://nodejs.org/api/crypto.html#crypto_crypto_generatekeypair_type_options_callback
  https://nodejs.org/api/crypto.html#crypto_crypto_diffiehellman_options

[typescript-bot]

@fuzzc0re Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• node on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 47238,
  "author": "fuzzc0re",
  "owners": [
    "Microsoft",
    "DefinitelyTyped",
    "jkomyno",
    "a-tarasyuk",
    "alvis",
    "r3nya",
    "btoueg",
    "brunoscheufler",
    "smac89",
    "touffy",
    "DeividasBakanas",
    "eyqs",
    "Flarna",
    "Hannes-Magnusson-CK",
    "KSXGitHub",
    "hoo29",
    "kjin",
    "ajafff",
    "islishude",
    "mwiktorczyk",
    "mohsen1",
    "n-e",
    "galkin",
    "parambirs",
    "eps1lon",
    "SimonSchick",
    "ThomasdenH",
    "WilcoBakker",
    "wwwy3y3",
    "samuela",
    "kuehlein",
    "j-oliveras",
    "bhongy",
    "chyzwar",
    "trivikr",
    "nguymin4",
    "yoursunny",
    "qwelias",
    "ExE-Boss",
    "Ryan-Willpower",
    "peterblazejewicz",
    "addaleax",
    "JasonHK"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "4a0c91d",
  "headCommitOid": "4a0c91d45fc65db336d4cf8c15c941e320aa532c",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-09-02T22:35:24.000Z",
  "lastCommentDate": "2020-09-03T21:50:36.000Z",
  "maintainerBlessed": true,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47238/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Critical",
  "newPackages": [],
  "packages": [
    "node"
  ],
  "files": [
    {
      "path": "types/node/test/crypto.ts",
      "kind": "test",
      "package": "node"
    },
    {
      "path": "types/node/ts3.1/crypto.d.ts",
      "kind": "definition",
      "package": "node"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-09-02T23:07:01.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @BrunoScheufler @smac89 @Touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[Flarna]

Please add also some test.
These crypto APIs are hard to follow for non crypto people like me. But I expect that you have working code somewhere you can port into a test here.

[Flarna]

docs tell that pkcs1 is only for RSA. Is it also allowed for X25519?

[fuzzc0re]

Sorry for that I just copied the committed ed25519 interface and changed letters. I corrected both in ac52918.

[Flarna]

docs tell that sec1 is only for EC. Is it also allowed for X25519?

[fuzzc0re]

Same as above. Sorry again.

[typescript-bot]

@fuzzc0re One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. If you disagree with the reviewer's comments, you can "dismiss" the review using GitHub's review UI. Thank you!

[typescript-bot]

@fuzzc0re The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[fuzzc0re]

The test in aa846a5 does not demonstrate a full symmetric key example with kdf and salt. It just tests that crypto.diffieHellman generates shared secrets properly.

[typescript-bot]

@fuzzc0re The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#47238	diff
Batch compilation
Memory usage (MiB)	105.1	106.7	+1.5%
Type count	17323	17353	0%
Assignability cache size	5023	5023	0%
Language service
Samples taken	39	39	0%
Identifiers in tests	39	39	0%
getCompletionsAtPosition
Mean duration (ms)	627.4	630.7	+0.5%
Mean CV	12.2%	11.1%
Worst duration (ms)	744.0	793.5	+6.7%
Worst identifier	wasm	NodeJS
getQuickInfoAtPosition
Mean duration (ms)	617.8	614.4	-0.5%
Mean CV	10.9%	9.8%	-10.3%
Worst duration (ms)	766.0	706.1	-7.8%
Worst identifier	global	Global

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@fuzzc0re The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[fuzzc0re]

Adds Typescript support for nodejs/node#26626 (comment).

[typescript-bot]

@Flarna Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[orta]

OK, looks good to me too - I'll leave it to a contributor to give it one more look over and you're welcome to merge

[fuzzc0re]

Ready to merge

[typescript-bot]

I just published @types/node@14.6.4 to npm.

[yoursunny]

Version 14.6.4 is sometimes causing this error:

error TS2688: Cannot find type definition file for 'node'.

https://travis-ci.com/github/yoursunny/NDNts/builds/182865199

The CI build randomly fails with the above error on some jobs, but if I retrigger the build, it would fail on a different set of jobs. However, I don't get this error if I downgrade to @types/node 14.6.3.

I have TypeScript 4.0.2.

I have a monorepo with pnpm and other weird stuff, so it's entirely possible that I messed up somewhere.
If anyone else is getting the same error, we can investigate more.

[fuzzc0re]

@yoursunny do you still get the same error? I am not sure but could it be the case that crypto.diffieHellman({ }) was added in node v13.9.0 and your supporting v12 is causing the error? I am not familiar with your setup so I might be completely wrong.

[yoursunny]

crypto.diffieHellman({ }) was added in node v13.9.0

I don't think it has anything to do with the contents of this PR. It's more likely that the way it's packaged and published was causing the problem.
I downgraded to 14.6.3 for now.