Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests in preparation for TS #31950 #36271

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Conversation

ahejlsberg
Copy link
Collaborator

Update tests in microsoft-ajax and mongoose/v3 in preparation for microsoft/TypeScript#31950.

@ahejlsberg ahejlsberg requested a review from horiuchi as a code owner June 19, 2019 00:00
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jun 19, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 19, 2019

@ahejlsberg Thank you for submitting this PR!

🔔 @pjmagee @horiuchi @lukasz-zak @Alorel @jendrikw @ethanresnick @vologab @jussikinnula @ondratra @alfirin @idandrd @various89 @Fazendaaa @NormanPerrin @danmana @stablio @emmanuelgautier @frontendmonster @mingchen @penumbra1 @orblazer @HughKu @niuware @Vladmel1234 @jloveridge @grimmer0125 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

microsoft-ajax/v*

Comparison details for microsoft-ajax/v* 📊
master #36271 diff
Batch compilation
Memory usage 76817024.0 80662664.0 +5.0%
Type count 9631 9629 0.0%
Assignability cache size 32601 32598 0.0%
Subtype cache size 3 2 -33.3%
Identity cache size 4 4 0.0%
Language service
Samples taken 1581 1581 0.0%
Identifiers in tests 1581 1581 0.0%
getCompletionsAtPosition
    Mean duration (ms) 385.0 378.3 -1.7%
    Median duration (ms) 382.5 376.7 -1.5%
    Mean CV 12.6% 13.3% +4.9%
    Worst duration (ms) 495.3 495.6 0.0%
    Worst identifier domElementObj Sys
getQuickInfoAtPosition
    Mean duration (ms) 397.5 388.0 -2.4%
    Median duration (ms) 396.0 385.8 -2.6%
    Mean CV 15.8% 15.6% -1.4%
    Worst duration (ms) 548.0 536.8 -2.0%
    Worst identifier set_errorHandled get_isDisposing

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

mongoose/v3

Comparison details for mongoose/v3 📊
master #36271 diff
Batch compilation
Memory usage 73035248.0 72550024.0 -0.7%
Type count 9553 9549 0.0%
Assignability cache size 1116 1116 0.0%
Subtype cache size 111 105 -5.4%
Identity cache size 0 0
Language service
Samples taken 1232 1232 0.0%
Identifiers in tests 1232 1232 0.0%
getCompletionsAtPosition
    Mean duration (ms) 370.7 377.1 +1.7%
    Median duration (ms) 368.7 375.1 +1.7%
    Mean CV 12.7% 13.0% +2.5%
    Worst duration (ms) 463.8 487.5 +5.1%
    Worst identifier populate read
getQuickInfoAtPosition
    Mean duration (ms) 382.9 391.1 +2.1%
    Median duration (ms) 381.6 387.4 +1.5%
    Mean CV 14.2% 14.2% -0.2%
    Worst duration (ms) 489.3 522.8 +6.8%
    Worst identifier type read

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@ahejlsberg ahejlsberg requested a review from weswigham June 19, 2019 16:33
@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Jun 19, 2019
@ahejlsberg ahejlsberg merged commit b051904 into master Jun 20, 2019
@ahejlsberg ahejlsberg deleted the prepare-for-ts31950 branch June 20, 2019 02:08
@typescript-bot
Copy link
Contributor

I just published @types/mongoose@3.8.36 to npm.

iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other Approved This PR was reviewed and signed-off by a community member. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants