Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/luxon] Add possible null interval intersection result #33154

Merged
merged 2 commits into from
Feb 20, 2019
Merged

[@types/luxon] Add possible null interval intersection result #33154

merged 2 commits into from
Feb 20, 2019

Conversation

kmontag
Copy link
Contributor

@kmontag kmontag commented Feb 18, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

a.intersection(b) for Intervals a and b will return null if a and b do not overlap. This adds null to the method's possible return types.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Feb 18, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 18, 2019

@kmontag Thank you for submitting this PR!

🔔 @colbydehart @FourwingsY @jsiebern @mastermatt @pietrovismara @dawnmist - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Contributor

@mastermatt mastermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Feb 18, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@amcasey amcasey merged commit b81d985 into DefinitelyTyped:master Feb 20, 2019
@typescript-bot
Copy link
Contributor

I just published @types/luxon@1.11.1 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants