Skip to content

Conversation

@kukoo1
Copy link
Contributor

@kukoo1 kukoo1 commented Aug 12, 2017

  1. add missing constructor options according to Sequelize documentation (database, username, password, retry, typeValidation [only v4])
  2. use RetryOptions interface for reuse and DRY purpose. {match?: string[], max?: number}
  3. add missing constructor signature, refer to above documentation example:
// with database, username, and password in the options object
const sequelize = new Sequelize({ database, username, password });

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

… typeValidation [only v4]), add RetryOptions interface for reuse and DRY purpose
@typescript-bot typescript-bot added the Unowned This PR touches a package that doesn't have any listed owners. label Aug 12, 2017
@kukoo1
Copy link
Contributor Author

kukoo1 commented Aug 13, 2017

@samuelneff Please review this PR :)

@mhegazy mhegazy merged commit bf2e0fa into DefinitelyTyped:master Aug 14, 2017
@kukoo1 kukoo1 deleted the sequelize-add-constructor-options1 branch August 15, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unowned This PR touches a package that doesn't have any listed owners.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants