Fix iOS 16 support #222
Merged
Fix iOS 16 support #222
+17
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
commented
Jan 17, 2025
| let siteManager = site.manager | ||
| let shouldSaveToManager = siteManager != nil || ProcessInfo().isOperatingSystemAtLeast(OperatingSystemVersion(majorVersion: 17, minorVersion: 0, patchVersion: 0)) | ||
|
|
||
| newSite?.save(manager: site.manager, saveToManager: shouldSaveToManager) { error in |
Contributor
Author
There was a problem hiding this comment.
This can be called from the NETunnelProviderManager process, in which case there is no manager, and we can't create one in older versions of iOS.
IanVS
commented
Jan 17, 2025
nbrownus
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of iOS, it's not possible to call
NETunnelProviderManager.loadAllFromPreferences()from inside the network extension process. We were seeingNETunnelProviderManager objects cannot be instantiated from NEProvider processeserrors in iOS 16. It's unclear exactly when the change happened to allow it, but as far as we can tell it was in iOS 17.To Test:
checkForUpdatefrom the mobile client. You should get aHost renewedaudit log for the host.