Fix system brightness setting #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrownus
previously approved these changes
Dec 20, 2024
johnmaguire
reviewed
Dec 20, 2024
johnmaguire
previously approved these changes
Dec 20, 2024
johnmaguire
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
Assume the system is set to dark mode. Previously, if you disabled system color in the app settings, then changed the dark mode switch to off, then turned system color back on, the app would stay light. Now, it will respect the system color correctly.
Previously the app would not change color if the system mode was changed. Now it listens for system brightness changes, and updates accordingly, if the setting for using system color is turned on.