-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReHold adapter #599
Add ReHold adapter #599
Conversation
The rehold adapter exports pools:
|
The rehold adapter exports pools: Test Suites: 1 passed, 1 total
|
hi, ty for adding. a few things:
the apr values, are they from the 12hour lock? |
Hello, We don't have pool addresses for pairs because we're using the single smart contract and determine earnings and tokens based on our staking plans (internal struct data in our smart contract). Should I use the pair of tokens addresses or some different for ID of a pool? APRs are extrapolated from 12 or 24 hours staking plans, that's right. I'll add a pool meta today for staking periods of pools. Thank you! |
@bifot yes pair address is fine. or some combi like |
I mean we don't have a pair address. We have addresses of two tokens of this pair. Or we can use the id (numeric) for a pair from our smart contract, is it ok? |
@slasher125 I've added the pool meta for each pool. |
The rehold adapter exports pools: Test Suites: 1 passed, 1 total
|
@slasher125 about IDs for pools with pairs, should I use these two tokens addresses in the ID or should I use our contract address? Examples:
|
i think the second option is better. i'd concat your current pool values with that address. ty |
@slasher125 ok, done. It will be the same id for every pool with two tokens. |
Error while running rehold adapter: Test Suites: 1 failed, 1 total
|
@slasher125 as I can see it's not allowed by tests to use non-unique IDs. I've reverted the previous commit. |
This reverts commit 1b7c219.
The rehold adapter exports pools: Test Suites: 1 passed, 1 total
|
yeah, what i mean was using it like this |
The rehold adapter exports pools: Test Suites: 1 passed, 1 total
|
@slasher125 done! ty |
@bifot sry only seeing this now: what i mean to use in poolMeta was something: |
@slasher125 I've used a reference from Uniswap V3 |
If it's too long, let's change to |
but isn't the lock based on the |
Yes, it is. But all of our pools have 12h and 24h plans. We always add these two options for every token and every pool. |
ah ok. but the yields differ depending on the duration? i'd expect 24h lock to have higher yields? |
APY is the same for 12h and 24h. |
btw, cause u shared the above screenshot: poolMeta will be displayed in () like the fee tier for the uni pool in the above screenshot. hence why it should be brief |
will update |
Should we set it as a description instead of a pool meta? If yes, we can write text longer like Uniswap V3 (started from "Calculateed as...") |
@slasher125 as I can see there's no link, can we fix it? |
@slasher125 can u check please? |
No description provided.