Skip to content

exclude dot dot finance#2327

Merged
0xkr3p merged 4 commits intoDefiLlama:masterfrom
0xkr3p:chore/exclude-dot-dot-finance
Feb 1, 2026
Merged

exclude dot dot finance#2327
0xkr3p merged 4 commits intoDefiLlama:masterfrom
0xkr3p:chore/exclude-dot-dot-finance

Conversation

@0xkr3p
Copy link
Contributor

@0xkr3p 0xkr3p commented Feb 1, 2026

  • DEPRECATED: This adapter is no longer functional.
  • The DotDot Finance API (api.dotdot.finance) has been shut down.
  • Website and API return HTTP 402 "Payment Required / DEPLOYMENT_DISABLED".
  • Protocol TVL is minimal (~$36K) with near-zero trading activity.
  • Excluded from yield server in src/utils/exclude.js
  • Date: 2026-02-01

Summary by CodeRabbit

  • Chores

    • Deprecated/removed the dot-dot-finance adapter from active use.
  • Bug Fixes

    • Adapter now fails gracefully when the external API is unavailable (returns no pools instead of causing errors) and logs the condition.
    • Internal data assembly adjusted to ensure consistent pool results when available.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Feb 1, 2026

📝 Walkthrough

Walkthrough

Adapter dot-dot-finance was marked deprecated and made resilient to API shutdown: data-fetching now wraps the flow in try/catch (returns empty array on failure), pool assembly was reworked, and the adapter was added to the exclusion list.

Changes

Cohort / File(s) Summary
Adapter — deprecation & error handling
src/adaptors/dot-dot-finance/index.ts
Added deprecation header; wrapped fetch/assembly in try/catch to return [] on API failure (logged); restructured pool/stakingPool assembly to combine tokens, tvlUsd, apy fields, underlying/reward token arrays, and preserve extraRewards.
Exclusion list
src/utils/exclude.js
Added 'dot-dot-finance' to excludeAdaptors with a deprecation comment noting API shutdown (deployment disabled).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 I nibbled logs and patched the flow,
The API slept — 402's the show,
I wrapped the calls in a careful snare,
Returned an empty hop when no data's there,
Now dot-dot rests in the exclude chair.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'exclude dot dot finance' directly summarizes the main change: excluding the dot-dot-finance adapter from the project due to API shutdown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xkr3p 0xkr3p merged commit d405662 into DefiLlama:master Feb 1, 2026
2 checks passed
@0xkr3p 0xkr3p deleted the chore/exclude-dot-dot-finance branch February 1, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant