Merged
Conversation
📝 WalkthroughWalkthroughUpdates the flamingo-finance data adaptor to use HTTPS CDN URLs instead of HTTP. Normalizes poolsData structure to support both array and object.pools formats, then enriches each pool object with standardized fields including chain, project, symbol, TVL, APY metrics, and token arrays. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The flamingo-finance adapter exports pools: Test Suites: 1 passed, 1 total |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/adaptors/flamingo-finance/index.js`:
- Around line 8-10: The code assumes poolsData is either an array or has a pools
property and will crash if poolsData is null/undefined or lacks pools; update
the assignment that creates pools (currently "const pools =
Array.isArray(poolsData) ? poolsData : poolsData.pools;") to defensively handle
these cases by using optional chaining and an empty-array fallback so pools is
always an array before the subsequent reduce call (reference symbols: poolsData,
pools, and the reduce invocation).
Comment on lines
+8
to
+10
| const pools = Array.isArray(poolsData) ? poolsData : poolsData.pools; | ||
|
|
||
| return pools.reduce((acc, p) => { |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n src/adaptors/flamingo-finance/index.js | head -30Repository: DefiLlama/yield-server
Length of output: 1146
🏁 Script executed:
#!/bin/bash
# Inspect the live CDN payload shape
curl -s https://flamingo-us-1.b-cdn.net/flamingo/analytics/flamingo/defillama-yields | jq 'type, keys? // "is-array"' | head -20Repository: DefiLlama/yield-server
Length of output: 173
🏁 Script executed:
rg -A 15 'getData\s*=' src/adaptors/utils.js | head -40Repository: DefiLlama/yield-server
Length of output: 553
🏁 Script executed:
rg -B 5 -A 10 'exports\.getData|function getData' src/adaptors/utils.jsRepository: DefiLlama/yield-server
Length of output: 397
🏁 Script executed:
rg -B 5 -A 25 'poolsFunction|exports' src/adaptors/flamingo-finance/index.jsRepository: DefiLlama/yield-server
Length of output: 1054
🏁 Script executed:
# Check if there's error handling in the adapter index or wrapper
fd index.js src/adaptors/ | head -5 | xargs rg -l 'module.exports|exports' | head -1 | xargs cat -n | tail -20Repository: DefiLlama/yield-server
Length of output: 676
Guard against null/undefined poolsData and missing pools property to prevent runtime crash.
The current code assumes poolsData.pools exists when poolsData is not an array. If the API returns null, undefined, or an object without a pools property, accessing .pools will throw a TypeError. Add defensive handling with optional chaining and an empty array fallback:
Proposed fix
- const pools = Array.isArray(poolsData) ? poolsData : poolsData.pools;
+ const pools = Array.isArray(poolsData)
+ ? poolsData
+ : Array.isArray(poolsData?.pools)
+ ? poolsData.pools
+ : [];🤖 Prompt for AI Agents
In `@src/adaptors/flamingo-finance/index.js` around lines 8 - 10, The code assumes
poolsData is either an array or has a pools property and will crash if poolsData
is null/undefined or lacks pools; update the assignment that creates pools
(currently "const pools = Array.isArray(poolsData) ? poolsData :
poolsData.pools;") to defensively handle these cases by using optional chaining
and an empty-array fallback so pools is always an array before the subsequent
reduce call (reference symbols: poolsData, pools, and the reduce invocation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.