Skip to content

Add severity for Veracode SCA hashcode calculation #7140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

coheigea
Copy link
Contributor

@coheigea coheigea commented Nov 15, 2022

On re-import, or if de-dup is enabled, it closes all other findings for a given component name/version that don't have a CVE (Veracode premium data). This takes the severity into account, so it doesn't end up closing a critical finding as a duplicate of a Low severity finding.

@github-actions github-actions bot added the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Nov 15, 2022
@coheigea coheigea force-pushed the coheigea/veracode-sca-severity branch 3 times, most recently from 820e5e2 to 1a7d531 Compare November 15, 2022 11:46
@Maffooch
Copy link
Contributor

@coheigea the unit test issue has been resolved by #7142
Please pull the latest dev branch to get that unit test to pass

@coheigea coheigea force-pushed the coheigea/veracode-sca-severity branch from 1a7d531 to 9143264 Compare November 15, 2022 20:06
@coheigea
Copy link
Contributor Author

@coheigea the unit test issue has been resolved by #7142 Please pull the latest dev branch to get that unit test to pass

Thanks @Maffooch , the tests are green again

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit 785ac3d into DefectDojo:dev Nov 20, 2022
@coheigea coheigea deleted the coheigea/veracode-sca-severity branch November 20, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants